Update sbt-microsites#3218
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3218 +/- ##
==========================================
- Coverage 93.38% 93.05% -0.34%
==========================================
Files 372 376 +4
Lines 7224 7412 +188
Branches 179 192 +13
==========================================
+ Hits 6746 6897 +151
- Misses 478 515 +37
Continue to review full report at Codecov.
|
LukaJCB
previously approved these changes
Dec 18, 2019
LukaJCB
approved these changes
Dec 18, 2019
fthomas
approved these changes
Dec 18, 2019
gagandeepkalra
added a commit
to gagandeepkalra/cats
that referenced
this pull request
Jan 4, 2020
gagandeepkalra
added a commit
to gagandeepkalra/cats
that referenced
this pull request
Jan 4, 2020
rossabaker
pushed a commit
that referenced
this pull request
Jan 6, 2020
* backported #3218 to fix `sbt docs/makeMicrosite` * attempting to fix 403's in dependency fetching by disabling coursier for docs * reverted disabling coursier for docs (the 403's fixed themselves somehow)
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I started migrating from Tut to mdoc but it doesn't feel practical:
def combineAllor whatever this really hurts readability (in some cases:resetis an option but in most it's not).nofail.There's probably other stuff but that's where I gave up.
I do think we should update sbt-microsites sooner rather than later, though, so I've made the bump and specifically set
WithTutand the old theme. I built it locally and everything looks fine.I also updated Jekyll in the Travis CI config, because I did a similar update for Circe this morning and being on an old version of Jekyll caused problems in a non-obvious way that was a huge pain to debug.