Update Scalafmt to 2.3.2#3232
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3232 +/- ##
==========================================
- Coverage 93.05% 93.04% -0.01%
==========================================
Files 376 376
Lines 7412 7407 -5
Branches 192 200 +8
==========================================
- Hits 6897 6892 -5
Misses 515 515
Continue to review full report at Codecov.
|
fthomas
approved these changes
Dec 31, 2019
rossabaker
approved these changes
Dec 31, 2019
Member
rossabaker
left a comment
There was a problem hiding this comment.
I think it's best to stay current and close to the defaults. 👍
Member
|
Agreed these changes are preferable. I do prefer a style where multi-line lambdas are always written with curlies instead of parens, but baby steps. This is still better than it was. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the update in #3228 but with the updated formatter actually run. Personally I like these changes, but if anyone has objections we could try to figure out whether it's possible to change the config to avoid them.