Skip to content

Update Scalafmt to 2.3.2#3232

Merged
djspiewak merged 2 commits into
typelevel:masterfrom
travisbrown:update/scalafmt-2.3.2
Dec 31, 2019
Merged

Update Scalafmt to 2.3.2#3232
djspiewak merged 2 commits into
typelevel:masterfrom
travisbrown:update/scalafmt-2.3.2

Conversation

@travisbrown
Copy link
Copy Markdown
Contributor

This is the update in #3228 but with the updated formatter actually run. Personally I like these changes, but if anyone has objections we could try to figure out whether it's possible to change the config to avoid them.

@codecov-io
Copy link
Copy Markdown

codecov-io commented Dec 30, 2019

Codecov Report

Merging #3232 into master will decrease coverage by <.01%.
The diff coverage is 85.58%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3232      +/-   ##
==========================================
- Coverage   93.05%   93.04%   -0.01%     
==========================================
  Files         376      376              
  Lines        7412     7407       -5     
  Branches      192      200       +8     
==========================================
- Hits         6897     6892       -5     
  Misses        515      515
Flag Coverage Δ
#scala_version_212 93.37% <84.9%> (-0.01%) ⬇️
#scala_version_213 92.78% <85.58%> (-0.05%) ⬇️
Impacted Files Coverage Δ
core/src/main/scala/cats/data/NonEmptyList.scala 98.7% <100%> (ø) ⬆️
...src/main/scala-2.13+/cats/instances/lazyList.scala 100% <100%> (ø) ⬆️
...ts/laws/discipline/InvariantSemigroupalTests.scala 100% <100%> (ø) ⬆️
.../main/scala-2.13+/cats/data/NonEmptyLazyList.scala 62.5% <100%> (ø) ⬆️
core/src/main/scala/cats/instances/vector.scala 100% <100%> (ø) ⬆️
core/src/main/scala/cats/instances/list.scala 100% <100%> (ø) ⬆️
core/src/main/scala/cats/Monad.scala 96.29% <100%> (ø) ⬆️
core/src/main/scala/cats/instances/future.scala 82.35% <100%> (ø) ⬆️
core/src/main/scala/cats/Reducible.scala 100% <100%> (ø) ⬆️
core/src/main/scala/cats/Foldable.scala 98.5% <100%> (ø) ⬆️
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 851f03b...66a7174. Read the comment docs.

Copy link
Copy Markdown
Member

@rossabaker rossabaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's best to stay current and close to the defaults. 👍

@djspiewak
Copy link
Copy Markdown
Member

Agreed these changes are preferable. I do prefer a style where multi-line lambdas are always written with curlies instead of parens, but baby steps. This is still better than it was.

@djspiewak djspiewak merged commit f44f251 into typelevel:master Dec 31, 2019
@travisbrown travisbrown added this to the 2.2.0-M1 milestone Jan 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants