First two missing instances#3380
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3380 +/- ##
==========================================
- Coverage 91.2% 91.18% -0.02%
==========================================
Files 373 378 +5
Lines 7683 7956 +273
Branches 197 227 +30
==========================================
+ Hits 7007 7255 +248
- Misses 676 701 +25
Continue to review full report at Codecov.
|
djspiewak
approved these changes
Apr 6, 2020
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3380 +/- ##
==========================================
+ Coverage 92.69% 92.70% +0.01%
==========================================
Files 379 379
Lines 7980 7981 +1
Branches 218 230 +12
==========================================
+ Hits 7397 7399 +2
+ Misses 583 582 -1 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Congrats to my colleague @CremboC on finding the first instance that didn't make it into implicit scope:
This affects any map where the element type doesn't have a commutative semigroup. Pre-2.2.0-M1 usage continues to work fine in 2.2.0-M1, you just need at least the
cats.kernel.instances.map._import.I've also added a missing
Align[Stream]on 2.12, which was turned up in #3378.I'll give us a couple of days to find any more of these (and maybe fix #3377) and then publish a second milestone.