Test freeJS with FastOptStage to save some CO2#3548
Merged
Conversation
djspiewak
approved these changes
Aug 3, 2020
Member
djspiewak
left a comment
djspiewak
left a comment
There was a problem hiding this comment.
But but… it's already in the cloud!
Codecov Report
@@ Coverage Diff @@
## master #3548 +/- ##
==========================================
+ Coverage 91.32% 91.40% +0.07%
==========================================
Files 386 386
Lines 8592 8540 -52
Branches 269 241 -28
==========================================
- Hits 7847 7806 -41
+ Misses 745 734 -11 |
Member
Author
|
Hmm I didn't see any difference - but now we should be able to run |
Member
Author
|
It could also depend on the node version / OS - we use a really old one on Travis (4) |
Member
|
Btw, doing a bit of digging… I think this setting is defaulted. |
Member
Author
Done in #3546 - it works |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.