Override map2Eval in FlatMap#3951
Merged
djspiewak merged 1 commit intotypelevel:mainfrom Jul 26, 2021
Merged
Conversation
djspiewak
approved these changes
Jul 25, 2021
LukaJCB
approved these changes
Jul 26, 2021
Contributor
Contributor
|
@xuwei-k I'm confused how your instance can be lawful and impacted by this change. That said, leaving map2/map2Eval to be the default in FlatMap is probably a deoptimization for many cases. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We noticed that if not explicitly overridden to support lazy evaluation of the right argument,
map2Evalcan cause StackOverflowErrors for effect types.Relevant Cats Effect issue.
typelevel/cats-effect#2095