feat: add Alternative instance for OptionT
#4028
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think this instance was removed at some point because OptionT is not distributive. See this analogue ticket: purescript/purescript-transformers#116 |
|
Maybe the solution would be to have |
|
I don't quite follow; is there a missing law? I assumed any issues would be caught by the laws. |
|
Hm, read some more of that thread. Seems I've stumbled on a troubled edge case. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was working in
OptionTand went to write aguard. I realized I had to do it inOptionand thentoOptionT[F], so I thought I would submit anAlternativeinstance forOptionT, since it already hasApplicativeandMonoidK.I'm a n00b on how the layers of implicit resolution work, so I hope I have done that correctly. I'm very happy to take feedback on what I need to do differently here.