Skip to content

Add stack-safety test for ContT#map#4335

Merged
armanbilge merged 1 commit intotypelevel:mainfrom
eigenvariable:eigenvariable/2950
Nov 4, 2022
Merged

Add stack-safety test for ContT#map#4335
armanbilge merged 1 commit intotypelevel:mainfrom
eigenvariable:eigenvariable/2950

Conversation

@eigenvariable
Copy link
Copy Markdown
Contributor

@eigenvariable eigenvariable commented Nov 3, 2022

Issue #2950 has a test that, as of its writing, blows up with a stack safety bug. Sometime in the subsequent 3 years, it must have been fixed. This PR adds the test.

cc @johnynek

Closes #2950.

@armanbilge armanbilge added the behind-the-scenes appreciated, but not user-facing label Nov 3, 2022
@armanbilge armanbilge changed the title test from issue 2950 Add stack-safety test for ContT#map Nov 3, 2022
Copy link
Copy Markdown
Contributor

@johnynek johnynek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for adding this!

Always great to have another regression test.

@armanbilge armanbilge merged commit 9c8c5ef into typelevel:main Nov 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

behind-the-scenes appreciated, but not user-facing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ContT.map is not stack-safe

3 participants