Add Show for Option and OptionT#600
Merged
Merged
Conversation
The OptionT Show instance just uses the Show instance for the wrapped `F[Option[A]]` as opposed to wrapping it in `OptionT(...)`. This is to match the current behavior of `XorT`, but I'm wondering if that's something we would want to change on both. It seems to me like the Show output should reflect the fact that the value is wrapped in a monad transformer, but I don't have particularly strong feelings about this.
Current coverage is
|
Member
|
👍 |
1 similar comment
Contributor
|
👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The OptionT Show instance just uses the Show instance for the wrapped
F[Option[A]]as opposed to wrapping it inOptionT(...). This is tomatch the current behavior of
XorT, but I'm wondering if that'ssomething we would want to change on both. It seems to me like the Show
output should reflect the fact that the value is wrapped in a monad
transformer, but I don't have particularly strong feelings about this.