Skip to content

Add WriterT Bifunctor#673

Merged
fthomas merged 2 commits into
typelevel:masterfrom
ceedubs:writert-bifunctor
Nov 19, 2015
Merged

Add WriterT Bifunctor#673
fthomas merged 2 commits into
typelevel:masterfrom
ceedubs:writert-bifunctor

Conversation

@ceedubs
Copy link
Copy Markdown
Contributor

@ceedubs ceedubs commented Nov 18, 2015

Knocks one item off of the checklist on #620.

Knocks one item off of the checklist on typelevel#620.
@ceedubs ceedubs mentioned this pull request Nov 18, 2015
19 tasks
@codecov-io
Copy link
Copy Markdown

Current coverage is 82.85%

Merging #673 into master will increase coverage by +1.39% as of 5d0bde0

@@            master    #673   diff @@
======================================
  Files          159     162     +3
  Stmts         2131    2217    +86
  Branches        72      74     +2
  Methods          0       0       
======================================
+ Hit           1736    1837   +101
  Partial          0       0       
+ Missed         395     380    -15

Review entire Coverage Diff as of 5d0bde0

Powered by Codecov. Updated on successful CI builds.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpicking, but given we seem to use the fully qualified name in other imports, maybe import cats.functor.Bifunctor

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like your style. Will do.

@adelbertc
Copy link
Copy Markdown
Contributor

👍

@fthomas
Copy link
Copy Markdown
Member

fthomas commented Nov 19, 2015

👍

fthomas added a commit that referenced this pull request Nov 19, 2015
@fthomas fthomas merged commit e87df11 into typelevel:master Nov 19, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants