Add getOrElseF method to XorT#705
Merged
Merged
Conversation
Contributor
Author
|
@ceedubs per gitter discussion, here's a first attempt at an implementation + test for XorT.getOrElseF |
Current coverage is
|
Contributor
|
👍 |
Contributor
There was a problem hiding this comment.
Extremely minor: I'd be inclined to use the following names for the captured values:
case Xor.Left(_) => default
case Xor.Right(b) => F.pure(b)As this doesn't actually result in any difference, I'm not sure I can really justify the nitpick though...
Contributor
|
👍 |
Contributor
Author
|
Easy enough to change. Update incoming. |
793b3e7 to
ec534f6
Compare
Contributor
Author
|
I'm pretending I didn't read the contributing file and force pushing the change anyway. Match parameters now updated per @ceedubs suggestion. |
Contributor
|
Thanks! |
Contributor
Author
|
Cool, thanks for the help! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.