Skip to content

Remove AA >: A constraint from XorT.orElse#725

Merged
fthomas merged 2 commits into
typelevel:masterfrom
ceedubs:xort-orElse
Dec 9, 2015
Merged

Remove AA >: A constraint from XorT.orElse#725
fthomas merged 2 commits into
typelevel:masterfrom
ceedubs:xort-orElse

Conversation

@ceedubs
Copy link
Copy Markdown
Contributor

@ceedubs ceedubs commented Dec 8, 2015

No description provided.

@codecov-io
Copy link
Copy Markdown

Current coverage is 85.75%

Merging #725 into master will increase coverage by +0.17% as of 43ffe19

@@            master    #725   diff @@
======================================
  Files          162     162       
  Stmts         2247    2247       
  Branches        74      74       
  Methods          0       0       
======================================
+ Hit           1923    1927     +4
  Partial          0       0       
+ Missed         324     320     -4

Review entire Coverage Diff as of 43ffe19

Powered by Codecov. Updated on successful CI builds.

@adelbertc
Copy link
Copy Markdown
Contributor

👍

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we are not using xor after match I think we can just remove xor => xor match { ... }.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yet another good catch. I pushed an update.

@fthomas
Copy link
Copy Markdown
Member

fthomas commented Dec 9, 2015

👍

fthomas added a commit that referenced this pull request Dec 9, 2015
Remove AA >: A constraint from XorT.orElse
@fthomas fthomas merged commit 32fa9e2 into typelevel:master Dec 9, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants