Use Eval instead of Trampoline for State#782
Merged
Merged
Conversation
This may provide the following benefits: 1) It should be a bit more efficient. 2) It removes the need to `import cats.std.function._` for some operations, which may make it a bit more newcomer friendly. 3) We are already using Eval for things like foldRight, so it seems more consistent to use it for `State`. 4) I think it's a bit easier to explain `Eval` than `Trampoline`, since it's hard to explain the latter without first explaining `Free`. So again, this may be a bit more newcomer friendly.
Contributor
Author
|
Paging @refried @non @jdegoes @adelbertc @stew @mpilquist as people who have shown interest in State and/or Eval previously. |
Current coverage is
|
Member
|
👍 I found working with |
Contributor
Author
|
I noticed there was an unused instance specialized to |
Contributor
|
👍 |
adelbertc
added a commit
that referenced
this pull request
Jan 8, 2016
Use Eval instead of Trampoline for State
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This may provide the following benefits:
import cats.std.function._for someoperations, which may make it a bit more newcomer friendly.
consistent to use it for
State.EvalthanTrampoline, sinceit's hard to explain the latter without first explaining
Free. Soagain, this may be a bit more newcomer friendly.
However, there may be downsides I haven't thought of. I thought I would throw this PR together for discussion. Thoughts?