Skip to content

Update free monad docs#832

Merged
ceedubs merged 1 commit into
typelevel:masterfrom
ceedubs:update-freemonad-docs
Feb 1, 2016
Merged

Update free monad docs#832
ceedubs merged 1 commit into
typelevel:masterfrom
ceedubs:update-freemonad-docs

Conversation

@ceedubs
Copy link
Copy Markdown
Contributor

@ceedubs ceedubs commented Jan 30, 2016

This resolves #804.

I also updated the "pure" compiler to use State. It previously had
said that a pure compiler couldn't be written and used with foldMap,
but that's not really true if you use something like State. I think
this is probably a cleaner and more useful solution.

@mandubian @raulraja would you be available to review?

This resolves typelevel#804.

I also updated the "pure" compiler to use `State`. It previously had
said that a pure compiler couldn't be written and used with `foldMap`,
but that's not really true if you use something like `State`. I think
this is probably a cleaner and more useful solution.
@codecov-io
Copy link
Copy Markdown

Current coverage is 89.26%

Merging #832 into master will decrease coverage by -0.04% as of 69c4737

@@            master    #832   diff @@
======================================
  Files          168     168       
  Stmts         2319    2319       
  Branches        75      75       
  Methods          0       0       
======================================
- Hit           2071    2070     -1
  Partial          0       0       
- Missed         248     249     +1

Review entire Coverage Diff as of 69c4737

Powered by Codecov. Updated on successful CI builds.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An alternative to liftF is to use Free.inject when targeting cats.data.Coproduct as a composition mechanism maybe it should be mentioned here.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess it's mentioned below. Perhaps we should consider adding some kind of TOC at the beginning of each tutorial to show at a glance the different sections and topics being described.

@raulraja
Copy link
Copy Markdown
Contributor

@ceedubs LGTM!. My comments are just suggestion for future consideration in case the tutorials become too long.

@non
Copy link
Copy Markdown
Contributor

non commented Feb 1, 2016

👍

@mandubian
Copy link
Copy Markdown
Contributor

yes that was required! thanks for the effort ;)
👍

@ceedubs
Copy link
Copy Markdown
Contributor Author

ceedubs commented Feb 1, 2016

Thanks for the quick feedback everyone. @raulraja I agree that tables of contents might be helpful in docs. I'll create a separate issue to track that.

@ceedubs ceedubs mentioned this pull request Feb 1, 2016
ceedubs added a commit that referenced this pull request Feb 1, 2016
@ceedubs ceedubs merged commit 5df87d3 into typelevel:master Feb 1, 2016
@ceedubs ceedubs deleted the update-freemonad-docs branch February 1, 2016 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update free monad tut for newer Free structure

6 participants