Skip to content

add -P:scalajs:mapSourceURI option#916

Merged
non merged 1 commit into
typelevel:masterfrom
xuwei-k:scalajs-mapSourceURI-option
Mar 7, 2016
Merged

add -P:scalajs:mapSourceURI option#916
non merged 1 commit into
typelevel:masterfrom
xuwei-k:scalajs-mapSourceURI-option

Conversation

@xuwei-k
Copy link
Copy Markdown
Contributor

@xuwei-k xuwei-k commented Mar 4, 2016

No description provided.

@codecov-io
Copy link
Copy Markdown

Current coverage is 88.78%

Merging #916 into master will not affect coverage as of fe093f8

@@            master    #916   diff @@
======================================
  Files          178     178       
  Stmts         2122    2122       
  Branches        42      42       
  Methods          0       0       
======================================
  Hit           1884    1884       
  Partial          0       0       
  Missed         238     238       

Review entire Coverage Diff as of fe093f8

Powered by Codecov. Updated on successful CI builds.

@milessabin
Copy link
Copy Markdown
Member

Does this change the release tag name?

@xuwei-k
Copy link
Copy Markdown
Contributor Author

xuwei-k commented Mar 7, 2016

Does this change the release tag name?

No, this is sbt-release plugin's default TaskKey[String] value.

https://github.com/sbt/sbt-release/blob/v1.0.3/src/main/scala/ReleasePlugin.scala#L194

@milessabin
Copy link
Copy Markdown
Member

Is there any way of using the release plugin's default value without duplicating the definition here?

@xuwei-k
Copy link
Copy Markdown
Contributor Author

xuwei-k commented Mar 7, 2016

releaseTagName is Task but scalacOptions is Setting, Setting can not depends on Task.

@milessabin
Copy link
Copy Markdown
Member

Gotcha.

@milessabin
Copy link
Copy Markdown
Member

👍

@non
Copy link
Copy Markdown
Contributor

non commented Mar 7, 2016

Thanks! 👍

non added a commit that referenced this pull request Mar 7, 2016
@non non merged commit ae7b531 into typelevel:master Mar 7, 2016
@xuwei-k xuwei-k deleted the scalajs-mapSourceURI-option branch March 7, 2016 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants