Switch off scaladoc generation for Scala 2.10 due to macro problems#958
Merged
Merged
Conversation
Contributor
|
Sounds good to me if it should fix #898. Thanks! |
Current coverage is
|
Member
|
I did the same for http4s for the same reason, and haven't had any regrets. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR would switch off scaladoc generation for Scala 2.10 during the makeSite process. The site generated in 2.10 mode would not have scaladoc generated, but would be otherwise identical to the site generated in 2.11 mode.
This allows documentation to be put together for all classes, and should allow #898 to pass the build.