-
Notifications
You must be signed in to change notification settings - Fork 82
Add a ConsoleLogger and ConsoleLoggerFactory #912
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
morgen-peschke
wants to merge
9
commits into
typelevel:main
Choose a base branch
from
morgen-peschke:add-a-simple-console-logger
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 4 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
116cb6c
Add a ConsoleLogger and ConsoleLoggerFactory
morgen-peschke 6717c2e
Fix accidental ifF to ifM
morgen-peschke b09d316
Avoid using pre 2.13 method
morgen-peschke f21ba99
Fix formatting
morgen-peschke de72914
Fix miswired log levels
morgen-peschke b09cf47
Allow ConsoleLogger to specify format
morgen-peschke 4ed0fd5
Use method that exists for JS
morgen-peschke f517111
Rename ConsoleLogger to StdErrLogger
morgen-peschke 6ae7f0b
Remove StdErrLogger.setLogLevel
morgen-peschke File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
323 changes: 323 additions & 0 deletions
323
core/shared/src/main/scala/org/typelevel/log4cats/extras/ConsoleLogger.scala
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,323 @@ | ||
/* | ||
* Copyright 2018 Typelevel | ||
* | ||
* Licensed under the Apache License, Version 2.0 (the "License"); | ||
* you may not use this file except in compliance with the License. | ||
* You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
*/ | ||
|
||
package org.typelevel.log4cats.extras | ||
|
||
import cats.{~>, Show} | ||
import cats.effect.kernel.{Async, Ref} | ||
import cats.effect.std.Console | ||
import cats.syntax.all.* | ||
import org.typelevel.log4cats.SelfAwareStructuredLogger | ||
|
||
import java.io.{ByteArrayOutputStream, PrintStream} | ||
|
||
/** | ||
* A simple logger that prints logs to standard error output. | ||
* | ||
* The intended use-case is for one-off scripts, examples, and other situations where a more | ||
* fully-featured and performance-optimized logger would be overkill | ||
* | ||
* Log output format is roughly: | ||
* {{{ | ||
* %level %name - %message | ||
* %ctx | ||
* %throwable | ||
* }}} | ||
*/ | ||
trait ConsoleLogger[F[_]] extends SelfAwareStructuredLogger[F] { | ||
|
||
/** | ||
* Because there is no `log4j` backend, the log level can be set directly | ||
*/ | ||
def setLogLevel(level: LogLevel): F[Unit] | ||
morgen-peschke marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
override def mapK[G[_]](fk: F ~> G): ConsoleLogger[G] = | ||
ConsoleLogger.mapK(this, fk) | ||
|
||
override def addContext(ctx: Map[String, String]): ConsoleLogger[F] = | ||
ConsoleLogger.withContext(this)(ctx) | ||
|
||
override def addContext(pairs: (String, Show.Shown)*): ConsoleLogger[F] = | ||
ConsoleLogger.withContext(this)( | ||
pairs.map { case (k, v) => (k, v.toString) }.toMap | ||
) | ||
|
||
override def withModifiedString(f: String => String): ConsoleLogger[F] = | ||
ConsoleLogger.withModifiedString(this, f) | ||
} | ||
object ConsoleLogger { | ||
def apply[F[_]](name: String, initialLogLevel: LogLevel)(implicit | ||
console: Console[F], | ||
F: Async[F] | ||
): F[ConsoleLogger[F]] = | ||
Ref[F].of(initialLogLevel).map { logLevelRef => | ||
new ConsoleLogger[F] { | ||
override def setLogLevel(level: LogLevel): F[Unit] = logLevelRef.set(level) | ||
|
||
private def isLevelEnabled(level: LogLevel): F[Boolean] = logLevelRef.get.map(_ >= level) | ||
|
||
override def isTraceEnabled: F[Boolean] = isLevelEnabled(LogLevel.Trace) | ||
override def isDebugEnabled: F[Boolean] = isLevelEnabled(LogLevel.Debug) | ||
override def isInfoEnabled: F[Boolean] = isLevelEnabled(LogLevel.Info) | ||
override def isWarnEnabled: F[Boolean] = isLevelEnabled(LogLevel.Warn) | ||
override def isErrorEnabled: F[Boolean] = isLevelEnabled(LogLevel.Error) | ||
|
||
private def renderThrowable(t: Throwable): F[String] = | ||
F.delay { | ||
val baos = new ByteArrayOutputStream() | ||
val ps = new PrintStream(baos) | ||
t.printStackTrace(ps) | ||
baos.toString.linesIterator.map(s => s" $s").mkString("\n") | ||
} | ||
|
||
private def renderContext(ctx: Map[String, String]): String = | ||
if (ctx.isEmpty) "" | ||
else { | ||
val builder = new StringBuilder() | ||
ctx.toVector.foreach { case (key, value) => | ||
builder.append(" ").append(key).append(" = ").append(value).append("\n") | ||
} | ||
builder.result() | ||
} | ||
|
||
private def log(level: LogLevel, msg: => String): F[Unit] = | ||
isLevelEnabled(level).ifM(console.errorln(s"$level $name - $msg"), F.unit) | ||
|
||
private def log(level: LogLevel, msg: => String, throwable: Throwable): F[Unit] = | ||
isLevelEnabled(level).ifM( | ||
renderThrowable(throwable).flatMap(t => console.errorln(s"$level $name - $msg\n$t")), | ||
F.unit | ||
) | ||
|
||
private def log(level: LogLevel, msg: => String, ctx: Map[String, String]): F[Unit] = | ||
isLevelEnabled(level).ifM( | ||
console.errorln(s"$level $name - $msg${renderContext(ctx)}"), | ||
F.unit | ||
) | ||
|
||
private def log( | ||
level: LogLevel, | ||
msg: => String, | ||
throwable: Throwable, | ||
ctx: Map[String, String] | ||
): F[Unit] = | ||
isLevelEnabled(level).ifM( | ||
renderThrowable(throwable) | ||
.flatMap(t => console.errorln(s"$level $name - $msg${renderContext(ctx)}\n$t")), | ||
F.unit | ||
) | ||
|
||
override def trace(ctx: Map[String, String])(msg: => String): F[Unit] = | ||
log(LogLevel.Error, msg, ctx) | ||
override def debug(ctx: Map[String, String])(msg: => String): F[Unit] = | ||
log(LogLevel.Warn, msg, ctx) | ||
override def info(ctx: Map[String, String])(msg: => String): F[Unit] = | ||
log(LogLevel.Info, msg, ctx) | ||
override def warn(ctx: Map[String, String])(msg: => String): F[Unit] = | ||
log(LogLevel.Debug, msg, ctx) | ||
override def error(ctx: Map[String, String])(msg: => String): F[Unit] = | ||
log(LogLevel.Trace, msg, ctx) | ||
|
||
override def trace(ctx: Map[String, String], t: Throwable)(msg: => String): F[Unit] = | ||
log(LogLevel.Error, msg, t, ctx) | ||
override def debug(ctx: Map[String, String], t: Throwable)(msg: => String): F[Unit] = | ||
log(LogLevel.Warn, msg, t, ctx) | ||
override def info(ctx: Map[String, String], t: Throwable)(msg: => String): F[Unit] = | ||
log(LogLevel.Info, msg, t, ctx) | ||
override def warn(ctx: Map[String, String], t: Throwable)(msg: => String): F[Unit] = | ||
log(LogLevel.Debug, msg, t, ctx) | ||
override def error(ctx: Map[String, String], t: Throwable)(msg: => String): F[Unit] = | ||
log(LogLevel.Trace, msg, t, ctx) | ||
morgen-peschke marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
override def error(t: Throwable)(message: => String): F[Unit] = | ||
log(LogLevel.Error, message, t) | ||
override def warn(t: Throwable)(message: => String): F[Unit] = | ||
log(LogLevel.Warn, message, t) | ||
override def info(t: Throwable)(message: => String): F[Unit] = | ||
log(LogLevel.Info, message, t) | ||
override def debug(t: Throwable)(message: => String): F[Unit] = | ||
log(LogLevel.Debug, message, t) | ||
override def trace(t: Throwable)(message: => String): F[Unit] = | ||
log(LogLevel.Trace, message, t) | ||
|
||
override def error(message: => String): F[Unit] = log(LogLevel.Error, message) | ||
override def warn(message: => String): F[Unit] = log(LogLevel.Warn, message) | ||
override def info(message: => String): F[Unit] = log(LogLevel.Info, message) | ||
override def debug(message: => String): F[Unit] = log(LogLevel.Debug, message) | ||
override def trace(message: => String): F[Unit] = log(LogLevel.Trace, message) | ||
} | ||
} | ||
|
||
private def mapK[F[_], G[_]]( | ||
logger: ConsoleLogger[F], | ||
fk: F ~> G | ||
): ConsoleLogger[G] = | ||
new ConsoleLogger[G] { | ||
override def setLogLevel(level: LogLevel): G[Unit] = fk(logger.setLogLevel(level)) | ||
|
||
override def isTraceEnabled: G[Boolean] = fk(logger.isTraceEnabled) | ||
override def isDebugEnabled: G[Boolean] = fk(logger.isDebugEnabled) | ||
override def isInfoEnabled: G[Boolean] = fk(logger.isInfoEnabled) | ||
override def isWarnEnabled: G[Boolean] = fk(logger.isWarnEnabled) | ||
override def isErrorEnabled: G[Boolean] = fk(logger.isErrorEnabled) | ||
|
||
override def trace(ctx: Map[String, String], t: Throwable)(msg: => String): G[Unit] = fk( | ||
logger.trace(ctx, t)(msg) | ||
) | ||
override def debug(ctx: Map[String, String], t: Throwable)(msg: => String): G[Unit] = fk( | ||
logger.debug(ctx, t)(msg) | ||
) | ||
override def info(ctx: Map[String, String], t: Throwable)(msg: => String): G[Unit] = fk( | ||
logger.info(ctx, t)(msg) | ||
) | ||
override def warn(ctx: Map[String, String], t: Throwable)(msg: => String): G[Unit] = fk( | ||
logger.warn(ctx, t)(msg) | ||
) | ||
override def error(ctx: Map[String, String], t: Throwable)(msg: => String): G[Unit] = fk( | ||
logger.error(ctx, t)(msg) | ||
) | ||
|
||
override def trace(ctx: Map[String, String])(msg: => String): G[Unit] = fk( | ||
logger.trace(ctx)(msg) | ||
) | ||
override def debug(ctx: Map[String, String])(msg: => String): G[Unit] = fk( | ||
logger.debug(ctx)(msg) | ||
) | ||
override def info(ctx: Map[String, String])(msg: => String): G[Unit] = fk( | ||
logger.info(ctx)(msg) | ||
) | ||
override def warn(ctx: Map[String, String])(msg: => String): G[Unit] = fk( | ||
logger.warn(ctx)(msg) | ||
) | ||
override def error(ctx: Map[String, String])(msg: => String): G[Unit] = fk( | ||
logger.error(ctx)(msg) | ||
) | ||
|
||
override def trace(t: Throwable)(message: => String): G[Unit] = fk(logger.trace(t)(message)) | ||
override def debug(t: Throwable)(message: => String): G[Unit] = fk(logger.debug(t)(message)) | ||
override def info(t: Throwable)(message: => String): G[Unit] = fk(logger.info(t)(message)) | ||
override def warn(t: Throwable)(message: => String): G[Unit] = fk(logger.warn(t)(message)) | ||
override def error(t: Throwable)(message: => String): G[Unit] = fk(logger.error(t)(message)) | ||
|
||
override def trace(message: => String): G[Unit] = fk(logger.trace(message)) | ||
override def debug(message: => String): G[Unit] = fk(logger.debug(message)) | ||
override def info(message: => String): G[Unit] = fk(logger.info(message)) | ||
override def warn(message: => String): G[Unit] = fk(logger.warn(message)) | ||
override def error(message: => String): G[Unit] = fk(logger.error(message)) | ||
} | ||
|
||
def withContext[F[_]]( | ||
logger: ConsoleLogger[F] | ||
)(baseCtx: Map[String, String]): ConsoleLogger[F] = | ||
new ConsoleLogger[F] { | ||
private def addCtx(ctx: Map[String, String]): Map[String, String] = baseCtx ++ ctx | ||
|
||
override def setLogLevel(level: LogLevel): F[Unit] = logger.setLogLevel(level) | ||
|
||
override def isTraceEnabled: F[Boolean] = logger.isTraceEnabled | ||
override def isDebugEnabled: F[Boolean] = logger.isDebugEnabled | ||
override def isInfoEnabled: F[Boolean] = logger.isInfoEnabled | ||
override def isWarnEnabled: F[Boolean] = logger.isWarnEnabled | ||
override def isErrorEnabled: F[Boolean] = logger.isErrorEnabled | ||
|
||
override def trace(ctx: Map[String, String], t: Throwable)(msg: => String): F[Unit] = | ||
logger.trace(addCtx(ctx), t)(msg) | ||
override def debug(ctx: Map[String, String], t: Throwable)(msg: => String): F[Unit] = | ||
logger.debug(addCtx(ctx), t)(msg) | ||
override def info(ctx: Map[String, String], t: Throwable)(msg: => String): F[Unit] = | ||
logger.info(addCtx(ctx), t)(msg) | ||
override def warn(ctx: Map[String, String], t: Throwable)(msg: => String): F[Unit] = | ||
logger.warn(addCtx(ctx), t)(msg) | ||
override def error(ctx: Map[String, String], t: Throwable)(msg: => String): F[Unit] = | ||
logger.error(addCtx(ctx), t)(msg) | ||
|
||
override def trace(ctx: Map[String, String])(msg: => String): F[Unit] = | ||
logger.trace(addCtx(ctx))(msg) | ||
override def debug(ctx: Map[String, String])(msg: => String): F[Unit] = | ||
logger.debug(addCtx(ctx))(msg) | ||
override def info(ctx: Map[String, String])(msg: => String): F[Unit] = | ||
logger.info(addCtx(ctx))(msg) | ||
override def warn(ctx: Map[String, String])(msg: => String): F[Unit] = | ||
logger.warn(addCtx(ctx))(msg) | ||
override def error(ctx: Map[String, String])(msg: => String): F[Unit] = | ||
logger.error(addCtx(ctx))(msg) | ||
|
||
override def trace(t: Throwable)(message: => String): F[Unit] = | ||
logger.trace(baseCtx, t)(message) | ||
override def debug(t: Throwable)(message: => String): F[Unit] = | ||
logger.debug(baseCtx, t)(message) | ||
override def info(t: Throwable)(message: => String): F[Unit] = | ||
logger.info(baseCtx, t)(message) | ||
override def warn(t: Throwable)(message: => String): F[Unit] = | ||
logger.warn(baseCtx, t)(message) | ||
override def error(t: Throwable)(message: => String): F[Unit] = | ||
logger.error(baseCtx, t)(message) | ||
|
||
override def trace(message: => String): F[Unit] = logger.trace(baseCtx)(message) | ||
override def debug(message: => String): F[Unit] = logger.debug(baseCtx)(message) | ||
override def info(message: => String): F[Unit] = logger.info(baseCtx)(message) | ||
override def warn(message: => String): F[Unit] = logger.warn(baseCtx)(message) | ||
override def error(message: => String): F[Unit] = logger.error(baseCtx)(message) | ||
} | ||
|
||
def withModifiedString[F[_]]( | ||
logger: ConsoleLogger[F], | ||
f: String => String | ||
): ConsoleLogger[F] = | ||
new ConsoleLogger[F] { | ||
override def setLogLevel(level: LogLevel): F[Unit] = logger.setLogLevel(level) | ||
|
||
override def isTraceEnabled: F[Boolean] = logger.isTraceEnabled | ||
override def isDebugEnabled: F[Boolean] = logger.isDebugEnabled | ||
override def isInfoEnabled: F[Boolean] = logger.isInfoEnabled | ||
override def isWarnEnabled: F[Boolean] = logger.isWarnEnabled | ||
override def isErrorEnabled: F[Boolean] = logger.isErrorEnabled | ||
|
||
override def trace(ctx: Map[String, String], t: Throwable)(msg: => String): F[Unit] = | ||
logger.trace(ctx, t)(f(msg)) | ||
override def debug(ctx: Map[String, String], t: Throwable)(msg: => String): F[Unit] = | ||
logger.debug(ctx, t)(f(msg)) | ||
override def info(ctx: Map[String, String], t: Throwable)(msg: => String): F[Unit] = | ||
logger.info(ctx, t)(f(msg)) | ||
override def warn(ctx: Map[String, String], t: Throwable)(msg: => String): F[Unit] = | ||
logger.warn(ctx, t)(f(msg)) | ||
override def error(ctx: Map[String, String], t: Throwable)(msg: => String): F[Unit] = | ||
logger.error(ctx, t)(f(msg)) | ||
|
||
override def trace(ctx: Map[String, String])(msg: => String): F[Unit] = | ||
logger.trace(ctx)(f(msg)) | ||
override def debug(ctx: Map[String, String])(msg: => String): F[Unit] = | ||
logger.debug(ctx)(f(msg)) | ||
override def info(ctx: Map[String, String])(msg: => String): F[Unit] = | ||
logger.info(ctx)(f(msg)) | ||
override def warn(ctx: Map[String, String])(msg: => String): F[Unit] = | ||
logger.warn(ctx)(f(msg)) | ||
override def error(ctx: Map[String, String])(msg: => String): F[Unit] = | ||
logger.error(ctx)(f(msg)) | ||
|
||
override def trace(t: Throwable)(message: => String): F[Unit] = logger.trace(t)(f(message)) | ||
override def debug(t: Throwable)(message: => String): F[Unit] = logger.debug(t)(f(message)) | ||
override def info(t: Throwable)(message: => String): F[Unit] = logger.info(t)(f(message)) | ||
override def warn(t: Throwable)(message: => String): F[Unit] = logger.warn(t)(f(message)) | ||
override def error(t: Throwable)(message: => String): F[Unit] = logger.error(t)(f(message)) | ||
|
||
override def trace(message: => String): F[Unit] = logger.trace(f(message)) | ||
override def debug(message: => String): F[Unit] = logger.debug(f(message)) | ||
override def info(message: => String): F[Unit] = logger.info(f(message)) | ||
override def warn(message: => String): F[Unit] = logger.warn(f(message)) | ||
override def error(message: => String): F[Unit] = logger.error(f(message)) | ||
} | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We already have the dedicated
js-console
module that exposesConsoleLogger
for JS. Shouldn't we either create a new module for JVM/Native to maintain consistency (perhapsextras
would be fine), or at the very least move the newConsoleLogger
to a JVM/Native-specific submodule, so it's only published for the mentioned platforms?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't really have the setup, but I'm kind of curious what this would do in JS. I'd assume that
Console
has an implementation on that platform 🤔It's all going on stderr, so I'd be open to renaming it
StdErrLogger
to avoid confusion.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought part of the goal was to have this available in core, without depending on other modules? Otherwise, I'd think we'd just use slf4j and slf4j-simple?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That is a core motivation - make it dead simple to use out-of-the-box, and avoid requiring users who don't need heavy configuration (like scastie examples or scripts) to remember the artifact coordinates for the stuff to make
slf4j-simple
work.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@danicheg following up on if the rename to
StdErrLogger
works for you as a disambiguation with the JSConsoleLogger