Skip to content

sync validation and api for es6/es5 usage #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jul 29, 2016
Merged

Conversation

pleerock
Copy link
Contributor

@pleerock pleerock commented Jul 18, 2016

fixes #22 and #23

@pleerock
Copy link
Contributor Author

@llwt I have published it under class-validator@next. There are some additional changes I would like to bring before I publish as latest. Try @next until that. If you want to contribute it would be great if you can provide test coverage for functionality you want (or any other functionality you think is important)

* master:
  removed 0.10 version of node from travis config
@sanex3339
Copy link

sanex3339 commented Jul 18, 2016

Right now ValidationError are exists in ValidationError[] array even if validation was success but with empty constraints

// @IsBoolean()

 ValidationError {
    target: 
     Options {
       compact: true,
       debugProtection: false,
       debugProtectionInterval: false,
       disableConsoleOutput: false,
       encodeUnicodeLiterals: true,
       reservedNames: [],
       rotateUnicodeArray: true,
       selfDefending: true,
       sourceMap: false,
       sourceMapMode: 'separate',
       unicodeArray: true,
       unicodeArrayThreshold: -1,
       wrapUnicodeArrayCalls: true },
    value: true,
    property: 'wrapUnicodeArrayCalls',
    children: [],
    constraints: {} } 

Umed Khudoiberdiev added 3 commits July 19, 2016 10:19
* master:
  added codecov settings files
  added test to reproduce #24 - this is expected behavior
  added test to reproduce #24
@sanex3339
Copy link

sanex3339 commented Jul 19, 2016

with alpha.2 still got empty errors

 ValidationError {
    value: 'separate',
    property: 'sourceMapMode',
    children: [],
    constraints: {} },

@pleerock pleerock merged commit 843451f into master Jul 29, 2016
@pleerock pleerock deleted the sync-validation branch July 29, 2016 18:02
@github-actions
Copy link

github-actions bot commented Aug 6, 2020

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Synchronous validation
2 participants