refactor: update build process to enable tree shaking #568
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi folks,
long-awaited refactor is here. As PR #258 is pretty old I moved main @HonoluluHenk idea to this PR and improved build process.
What is done:
import { IsString } from 'class-validator';
Breaking changes:
[email protected]
- will mentione in changelog laterValidationTypes.CUSTOM_VALIDATION
now - mostly internal changeValidator
class was removed - because of tree shaking. So you have to use:instead of:
TODO:
validator
lib tree shakeable feature and push bundle size down event moreTesting:
This PR is published under
class-validator@tree-shaking
tag. I would like to ask everyone for help in testing and reviewing PR. I tested it on simple boilerplate angular 8 application and results are:@IsPhoneNumber
validator used:@IsPhoneNumber
:Close #258
Close #248
Close #247
Close #212