Open
Conversation
Reduce redundant calls to AbsSymlink in ResolveUntilLastSymlink.
rminnich
requested changes
Mar 19, 2026
Member
rminnich
left a comment
There was a problem hiding this comment.
This may well be an improvement but in the most common case, there is one symlink. In the outlier case there are 2. I'm not sure the performance benefit is worth the additional complexity.
Member
|
I do hope my review does not discourage you from contributing, I had not looked at the PRs for a while (I will do so more frequently) and missed this one. I wonder if you could look at the many places in this tree that the go version is specified as go 1. and see if they should be brought up to date? If you want to continue with this PR, I think we need more tests. This is code that must never break, as it is the core of the runtime, and I get worried about too much complexity. Thank you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the
mainpackage of gobusybox binaries, reduce redundant calls toAbsSymlinkinResolveUntilLastSymlink.This reduces string manipulations when resolving symlinks of
os.Argv[0].