Source list of entity filter with subdomain is not looked up correctly

Details

Prerequisites

• I verified that this is not a filter issue
  • Filter issues MUST be reported at filter issue tracker
• This is not a support issue or a question
  • Support issues and questions are handled at /r/uBlockOrigin
• I performed a cursory search of the issue tracker to avoid opening a duplicate issue
  • Your issue may already be reported.
• I tried to reproduce the issue when...
  • uBlock Origin is the only extension
  • uBlock Origin with default lists/settings
  • using a new, unmodified browser profile
• I am running the latest version of uBlock Origin
• I checked the documentation to understand that the issue I report is not a normal behavior

Description

Logger details view for www.example.*##p shows "Static filter ##p could not be found in any of the currently enabled filter lists"

@okiehsch found it here: uBlockOrigin/uAssets#6637 (comment)

This started with gorhill/uBlock@a73dd0a and obviously before this commit scriptlet is not even logged.

reEntity, ^gmx\.\*$ does not match www.gmx.com in reverselookup-worker.js, hostnameMatches function.

A specific URL where the issue occurs

• http://www.example.com/

Steps to Reproduce

1. add www.example.*##p to My filters
2. open logger
3. open http://www.example.com/
4. click on p entry in the logger

Expected behavior:

Filter list
My filters

Actual behavior:

Filter list
Static filter ##p could not be found in any of the currently enabled filter lists

Your environment

• uBlock Origin version: 1.23, 1.24.3b2
• Browser Name and version: Chrome, Firefox
• Operating System and version:

---

This seems to work:

diff --git a/src/js/reverselookup-worker.js b/src/js/reverselookup-worker.js
index eb12ccea..3042e5fc 100644
--- a/src/js/reverselookup-worker.js
+++ b/src/js/reverselookup-worker.js
@@ -141,8 +141,8 @@ const fromCosmeticFilter = function(details) {
     );
 
     let reEntity,
-        domain = details.domain,
-        pos = domain.indexOf('.');
+        domain = details.hostname,
+        pos = domain.lastIndexOf('.');
     if ( pos !== -1 ) {
         reEntity = new RegExp(
             '^' +

[uBlock-user]

I'm experiencing the same at https://www.kyivpost.com/article/opinion/op-ed/sergii-leshchenko-the-true-story-of-yanukovychs-black-ledger.html with exception filters there. Related ?

Different. I think this time reverse-lookup confuses this filter with regex...

This one from Fanboy Annoyance?

@@/wp-content/plugins/super-socializer/js/front/social_login/*$~third-party

There is * at the end, and I think this was recently corrected to be removed for some reason.

[uBlock-user]

So a different issue with similar conditions ?

This one from Fanboy Annoyance?

Seems so, I can't tell. I have many stock filterlists activated.

I think you have found regression from the regression fix gorhill/uBlock@7c0294b

I'm not sure, but badfilter seems to be broken too.

[uBlock-user]

The same filter is present in Fanboy Social too...

I'm not sure, but badfilter seems to be broken too.

because it can't locate where the filter is before it can badfilter it ? So by-design broken too ?

I did not followed more in debugger, but when * is missing, filter is detected as regex (because of /.../) and re-compiled (passed to RegExp(...)) to "normalize" regex syntax. This causes all / to be escaped \/ and that's probably why it does not match anymore.

---

This one is looked-up correctly to My filters:
@@/wp-content\/plugins\/super-socializer\/js\/front\/social_login/$1p

edit: wrong assumption - no * at the end

[okiehsch]

I'm not sure, but badfilter seems to be broken too.

@@/wp-content/plugins/super-socializer/js/front/social_login/*$~third-party,badfilter
works on my end.

[uBlock-user]

badfilter for @@/wp-content/plugins/super-socializer/js/front/social_login/$1p won't work.

[okiehsch]

Works on my end.

[uBlock-user]

I added the wrong one, it would be --

@@/wp-content/plugins/super-socializer/js/front/social_login/$1p,badfilter doesn't get applied on my Nightly.

Logger will report filter without the * so it will not work for original filter with the *.

[okiehsch]

Same result on my end Firefox stable with the latest uBO-dev.

@@/wp-content/plugins/super-socializer/js/front/social_login/*$1p
@@/wp-content/plugins/super-socializer/js/front/social_login/$1p,badfilter

Try this. You will not know original filter is with * - logger does not show this.