Skip to content

Conversation

@cbeach47
Copy link
Contributor

@cbeach47 cbeach47 commented Dec 1, 2017

From https://issues.jasig.org/browse/ANNPLT-131

The Window's build was failing (in part) due to the file exclusion patterns not having Window's style slashes. There's still more work on this however, the 'mvn clean install' command on Windows is failing with a generic NPE and running schemagen standalone only has some classpath errors. might be the problem, however the classpath is similar to the schemagen classpath when run in Linux.

@ChristianMurphy
Copy link
Member

ChristianMurphy commented Dec 1, 2017

Thanks @cbeach47! 🙇

@drewwills any chance the AppVeyor for PRs could be enabled?

@ChristianMurphy ChristianMurphy self-requested a review December 1, 2017 20:41
@drewwills
Copy link
Contributor

@cbeach47 -- You've been very busy. :)

Could you try something for me? Put aside (for now) all the changes you've been working on for this issue (maybe use a new branch off master) and add...

<pattern>SchemaCreator\.java</pattern>

To the <patterns> element within the jaxb2-maven-plugin config? It appears that it was overlooked.

@cbeach47
Copy link
Contributor Author

cbeach47 commented Dec 2, 2017

Tried adding that exclusion pattern with and without these changes, but still getting the SchemaGen 'Unknown error' / NPE. Changed Arrays to a standard class, and excluded a few more classes. Only SchemaGen classpath error now is log4j. Adding in a Maven dependency specifically in the plugin didn't help.

@cbeach47 cbeach47 mentioned this pull request Dec 5, 2017
Copy link
Member

@ChristianMurphy ChristianMurphy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved at #60 (comment)

Barring any objections this will be merged later today.

@ChristianMurphy ChristianMurphy merged commit 50cbf91 into uPortal-Project:master Dec 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants