Replaced Log4j with Logback #70
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
ChristianMurphy
approved these changes
Apr 11, 2018
Member
ChristianMurphy
left a comment
ChristianMurphy
left a comment
There was a problem hiding this comment.
LGTM, thanks @jonathanmtran! 🙇
Related, non-blocking comment, project lombok provides some nice abstractions for logging (among other things)
https://projectlombok.org/features/log
It has for other portlets, helped keep the code DRY and standardized
uPortal-Project/JasigWidgetPortlets#34
bjagg
approved these changes
May 23, 2018
Member
bjagg
left a comment
bjagg
left a comment
There was a problem hiding this comment.
Looks good and I'll merge this in.
Just quick note that James had created a write-up on logging best practices here: https://wiki.jasig.org/display/UPM40/Logging+Best+Practices
Fixed conflict typo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Description of change
Replaced Log4j with Logback to get file rotations + deletion of old log files. [1]
This could use additional eyeballs to ensure that no regressions are introduced from this change.
[1] uPortal-Project/uPortal-start#133 (comment)