Add JSON Resource endpoints for emergencies and normal messages #73
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChristianMurphy
approved these changes
May 17, 2018
Member
ChristianMurphy
left a comment
ChristianMurphy
left a comment
There was a problem hiding this comment.
Great to see more REST endpoints! 👍
| <version>${jackson.version}</version> | ||
| </dependency> | ||
| <dependency> | ||
| <groupId>org.projectlombok</groupId> |
Member
There was a problem hiding this comment.
I like to see lombok being used.
Is it being used?
| // to emergency announcements into their own list | ||
| for (TopicSubscription ts : myTopics) { | ||
| if (ts.getSubscribed() && ts.getTopic().getSubscriptionMethod() != Topic.EMERGENCY) { | ||
| announcements1.addAll(ts.getTopic().getPublishedAnnouncements()); |
Member
There was a problem hiding this comment.
Member
Author
There was a problem hiding this comment.
Well, I thought that the stream() version would be longer and harder to understand; however, after digging in and refining, I was able to remove other lines to make the stream() version smaller. Thanks for the push. This was also the first time I used flatMap() in Java.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #71