Changes to support splitting CI build into multiple containers. #1889
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryanrath
added
Category:Infrastructure
ShixinWu16
force-pushed
the
file_updates_for_refactoring_docker_files
branch
from
6ee958a to
16e723d
Compare
jpwhite4
changed the title
ryanrath
force-pushed
the
file_updates_for_refactoring_docker_files
branch
from
16e723d to
9a78740
Compare
-
tests/artifacts/xdmod/etlv2/configuration/output/normalized_table_definition.json:
- Updated to use the new docker network name.
- tests/ci/bootstrap.sh
- removed the database related setup.
- tests/ci/scripts/xdmod-setup-start.tcl:
- Updated to use the new docker network naeme.
- tests/playwright/Docker/docker-compose.yml
- Added the `mariadb` container
- Added a new `05-skipcache.cnf` file that disables the feature that
makes mariadb use ip addresses vs. dns names as our code assumes
that our db users are `username@hostname`.
- Added a modified version of `/root/bin/services` that does not have
the db related commands in it. Of note, the order of the services
stopping / starting is intentional. If httpd is the first thing
stopped / started an error occurred on start about port 80 still
being in use thus causing restarts to fail.
- Added a `my.cnf` file that is mapped into the xdmod container as
`/root/.my.cnf` since we run a few raw `mysql` commands assuming we
are connecting to localhost.
ryanrath
force-pushed
the
file_updates_for_refactoring_docker_files
branch
from
5b5487a to
cda8844
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: The upgrade build will not pass as we don't currently have a way to automagically migrate an existing installations data from one database to another. Further thought / discussion will be needed
Description
Changes to support XDMoD database on an external host
Added a check for if the user was created
Added a question to get XDMoD host
Changed from using bootstrap to entrypoint (in create docker images repo)
#### Updated collation from utf8_general_ci to utf8_unicode_ciconfiguration/etl/etl_tables.d/*tests/artifacts/xdmod/etlv2/configuration/input/*tests/artifacts/xdmod/etlv2/configuration/output/*tests/unit/lib/ETL/DbModel/*Update ryanrath: The above changes were merged in a different PR and as such have been removed from this PR
Motivation and Context
We wanted to split up the docker containers so that each module has their own container.
This would allow us to share our docker images without having to share everything.
Tests performed
Ran all automated tests, changed tests to match new collation sets
Checklist: