Updates to support the Allocations Realm #2122
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpwhite4
force-pushed
the
allocations_updates
branch
3 times, most recently
from
868349d to
995f475
Compare
jpwhite4
force-pushed
the
allocations_updates
branch
from
995f475 to
864d7fd
Compare
eiffel777
reviewed
Nov 25, 2025
| return array($selectSql, $insertSql, $optimizedInsertSql); | ||
| } | ||
|
|
||
| protected function createStageBatchTempTable($minDayId, $maxDayId, $availableParams) |
Contributor
There was a problem hiding this comment.
It would be nice to have a docblock for this function describing it and it parameters
|
|
||
| public function __construct($schema, $table, $database = 'datawarehouse', $last_modified_column = 'last_modified') { | ||
|
|
||
| $this->schema = $schema; |
Contributor
There was a problem hiding this comment.
There seems to be some class properties like this that do not have DocBlocks. It would be nice if all these properties had docblocks with their description and type.
| } | ||
| } | ||
|
|
||
| protected function stageData($aggregationUnit, $availableParams) |
Contributor
There was a problem hiding this comment.
It would be nice to have a docblock for this function describing it and it parameters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description