Skip to content

Conversation

@aestoltm
Copy link
Contributor

@aestoltm aestoltm commented Dec 3, 2025

Description

Chart exporting before would essentially run the same steps that we did in html/gui/js/PlotlyChartWrapper.js. The function XDMoD.utils.createChart() should have been called before but ran into namespace issues back during the Highcharts conversion.

This is an attempt to properly export the chart. This approach will help avoid bugs by not needing to replicate chart fixups within the export file but instead running the same chart function used in the portal.

This also fixes a bug with the time zone code (present in html/gui/js/PlotlyChartWrapper.js) but not in html/plotly_template.html which was the motivation for these changes and to move away from this approach of duplicating code (which is not even correctly duplicated)

Motivation and Context

Original approach was difficult to maintain and easy to introduce export bugs. Now everything runs through the same function (unless Job Viewer plots). The reason job viewer plots are different is because during the Highcharts conversion those were done first and we still needed to support the original Highcharts exporting for the rest of the portal.

Now that everything is in Plotly. There should be another PR to move the Job Viewer chart generation code into html/gui/js/PlotlyChartWrapper.js so that there is truly one function call. However, that should be a separate PR because it is much more involved.

Tests performed

Tested on my dev port

Checklist:

  • The pull request description is suitable for a Changelog entry
  • The milestone is set correctly on the pull request
  • The appropriate labels have been added to the pull request

@aestoltm aestoltm mentioned this pull request Dec 3, 2025
3 tasks
@aestoltm aestoltm requested a review from aaronweeden December 4, 2025 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant