fix: ensure ZFS_MINOR_VERSION pin is respected #436
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ARG ZFS_MINOR_VERSION was too early in Containerfile, before the last FROM statement before building ZFS kmod, thus it was ignored by the RUN which built the kmod. This moves it into the correct location and adds an echo to debug what the provided version actually was. Since zpools created on 2.4.0 can still be imported in 2.3.5 (verified in local testing), this will not only ensure we don't have this occur again, but revert to 2.3.x for now.
KyleGospo
approved these changes
Dec 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ARG ZFS_MINOR_VERSION was too early in Containerfile, before the last FROM statement before building ZFS kmod, thus it was ignored by the RUN which built the kmod.
This moves it into the correct location and adds an echo to debug what the provided version actually was.
Since zpools created on 2.4.0 can still be imported in 2.3.5 (verified in local testing), this will not only ensure we don't have this occur again, but revert to 2.3.x for now.
Note that CentOS failures are related to NVIDIA and not this change.