Skip to content

Working On New Feature: Compact Mode #579

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

ochi12
Copy link
Contributor

@ochi12 ochi12 commented May 11, 2025

Initial Progress

added preferences entry:
image

This is the best thing I can do rn but it is functional

Screencast.From.2025-05-12.13-35-52.webm

discussed in #554, user concerns about the distance between the indicators and I myself agree with it.

@ochi12
Copy link
Contributor Author

ochi12 commented May 12, 2025

Based arround system-status-indicator

Screencast.From.2025-05-12.15-03-07.webm

@ochi12
Copy link
Contributor Author

ochi12 commented May 12, 2025

@3v1n0 In case this ends up merged. I think we need to declare a css class name in Yaru

@frozen-cdn
Copy link

I need this functionality! Thank you! My icons are too far apart

if (settings.get_boolean('compact-mode-enabled'))
return '-natural-hpadding: 10px';
else
return '-natural-hpadding: 16px'; // from .system-status-icon
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we just set no value if using the shells default? I'd prefer not to have to maintain deltas like this that I'd forget about...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you mean like this?

   static get DEFAULT_STYLE() {
        const settings = SettingsManager.getDefaultGSettings();
        if (!settings.get_boolean('compact-mode-enabled'))
            return null; // drop to default -natural-hpadding.
        return '-natural-hpadding: 10px';
    }

and it is working just fine

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@3v1n0 is your input needed here for this to move along? Several of us are waiting for this...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants