Working On New Feature: Compact Mode #579
Open
+51
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Based arround system-status-indicator Screencast.From.2025-05-12.15-03-07.webm |
|
@3v1n0 In case this ends up merged. I think we need to declare a css class name in Yaru |
|
I need this functionality! Thank you! My icons are too far apart |
3v1n0
reviewed
Jul 7, 2025
| if (settings.get_boolean('compact-mode-enabled')) | ||
| return '-natural-hpadding: 10px'; | ||
| else | ||
| return '-natural-hpadding: 16px'; // from .system-status-icon |
There was a problem hiding this comment.
Can we just set no value if using the shells default? I'd prefer not to have to maintain deltas like this that I'd forget about...
There was a problem hiding this comment.
you mean like this?
static get DEFAULT_STYLE() {
const settings = SettingsManager.getDefaultGSettings();
if (!settings.get_boolean('compact-mode-enabled'))
return null; // drop to default -natural-hpadding.
return '-natural-hpadding: 10px';
}and it is working just fine
There was a problem hiding this comment.
@3v1n0 is your input needed here for this to move along? Several of us are waiting for this...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial Progress
added preferences entry:
This is the best thing I can do rn but it is functional
Screencast.From.2025-05-12.13-35-52.webm
discussed in #554, user concerns about the distance between the indicators and I myself agree with it.