Swapping icons to Font Awesome, improves icon accessibility #148
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattxwang
changed the title
evanzhong
approved these changes
May 13, 2021
| @@ -13,7 +13,7 @@ function Footer(){ | |||
| </div> | |||
| <div className="footer-item"> | |||
| <h3>Reach us at</h3> | |||
| <a href="mailto: [email protected]" className="email"><span>[email protected]</span></a> | |||
| <a href="mailto: [email protected]" className="email"><span className="footer-text">[email protected]</span></a> | |||
There was a problem hiding this comment.
Curious what the forcing function is for this change
There was a problem hiding this comment.
Great q! It's because there's a very generic span selector in this line of this file that was being applied to the buttons inadvertently, so I specified it. There's no impact on the final render for the non-icons.
|
Thanks for the reviews y'all ❤️ |
mattxwang
added a commit
that referenced
this pull request
May 13, 2021
This PR does a couple of things: * update `react-scripts` (the package for create-react-app) to `v4.0.3` - this is a major breaking change, but also helps with #130 * update `eslint` to v7+, to resolve newly-created peer-dependency mismatches * removes some unused CSS I forgot to remove from #148 * changes the about diamond to a `src/assets`-imported image rather than using a `background-image` hack (the nice externality is that it's also more accessible)! Closes #136.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Concisely, this PR does a couple of things:
aria-labeltags to make icon links accessiblepublic/folderThis PR is related to three issues:
public/folder)The components/pages we hit are:
<SocialMedia/>CTA, which is on every page - needed to also adjust some in specific CSS<SocialMedia/>CTAs on the home page and the about pageAnd some other relevant notes:
1.02), I change the color of the link. I feel that this is easier to see (and thus more accessible), plus causes less layout jank.Let me know what y'all think 😊