-
Notifications
You must be signed in to change notification settings - Fork 12
💥 Add strong type definition for fetch().json()
#26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@uhyo I don't know why the check is failing. It's working for me locally. |
I even got a different error. Let me try upgrading Node.js version on CI first 😨 |
@aaditmshah Running Anyway thank you for this! The first improvement in |
Downgraded to node version 16 and generated a We should probably add an |
Oh actually using version 3 would be file. I guess there was just something wrong with original commit. I tested locally with latest npm and it seems to work. Also Node.js on CI has been upgraded to CI should be happy with v3 lockfiles. |
cc70530
to
f4d8221
Compare
CI was falling again so I pushed the result of |
Looks good to me. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, thank you 😃
I think I can release tomorrow 🙂 |
Closes #24. You can review this PR on a per-commit basis. Here are the main changes that I made.
TypeScript/src/lib/libs.json
file to get the list of lib files.lib.dom.d.ts
file.build:lib
andbuild:diff
commands to regenerate the assets.@typescript/lib-header
from the list of dependencies in thetests
directory.fetch().json()
.