Skip to content

feat: add widget support for all UI libraries & install react-number-…#1206

Merged
ukrbublik merged 21 commits into
ukrbublik:masterfrom
mahtabhnp:feat/thousand-separator
May 16, 2025
Merged

feat: add widget support for all UI libraries & install react-number-…#1206
ukrbublik merged 21 commits into
ukrbublik:masterfrom
mahtabhnp:feat/thousand-separator

Conversation

@mahtabhnp

Copy link
Copy Markdown
Contributor

…format

@codesandbox

codesandbox Bot commented Feb 15, 2025

Copy link
Copy Markdown

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

@vercel

vercel Bot commented Feb 15, 2025

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-awesome-query-builder-examples ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 16, 2025 2:56pm
react-awesome-query-builder-sandbox ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 16, 2025 2:56pm
react-awesome-query-builder-sandbox-next ✅ Ready (Inspect) Visit Preview May 16, 2025 2:56pm

@codesandbox-ci

codesandbox-ci Bot commented Feb 15, 2025

Copy link
Copy Markdown

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 130d5ce:

Sandbox Source
@react-awesome-query-builder/examples Configuration
@react-awesome-query-builder/sandbox Configuration
@react-awesome-query-builder/sandbox-simple Configuration
@react-awesome-query-builder/sandbox-next Configuration

@ukrbublik

Copy link
Copy Markdown
Owner

Please resolve merge conflicts

Comment thread package.json Outdated
"typescript": "~5.4.5"
},
"dependencies": {
"react-number-format": "^5.0.0"

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should add it to package.json in packagesdir, not in root package.json

@ukrbublik

Copy link
Copy Markdown
Owner

Could you please apply the styles for new input to make it look and fell more natural to corresponding UI frameworks (MUI, AntDesign, Fluent) (like same height, border style)?
Screenshot 2025-02-23 at 12 48 54
Screenshot 2025-02-23 at 12 49 09
Screenshot 2025-02-23 at 12 49 36

@mahtabhnp

mahtabhnp commented Feb 25, 2025

Copy link
Copy Markdown
Contributor Author

Hi,

I just wanted to follow up and check if the task has been code-reviewed yet. I’ve pushed the comments, and I’d appreciate it if you could let me know if you have any feedback or thoughts on the PR.
@ukrbublik

Thanks!

@ukrbublik

ukrbublik commented Mar 1, 2025

Copy link
Copy Markdown
Owner

Please keep pnpm-lock version 6. You changed it to 9 which led to failed checks. We use pnpm v8.

Also could you please revert formatting changes (like adding/removing whitespace, \n, (, ), ,) like in packages/antd/modules/config/index.jsx, packages/sandbox_next/lib/config_base.ts (probably caused by your linter or prettifier)? To keep changes clean.

Otherwise changes looks good.

If you use VSCode you can see useful commands in bottom bar like "i" (install pnpm 8 and packages), "examples" (run example app on port 3001), "lint", "test". Running "i" should fix issues with lock file
Screenshot 2025-03-01 at 14 24 23

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

How can we set thousand separator input number?

2 participants