V15 migrations skip properties that vary by culture when the parent content type is invariant

[giano574]

Which Umbraco version are you using?

15.0.0

Bug summary

During the upgrade to Umbraco 15, certain migrations (e.g. ConvertLocalLinks, ConvertBlockEditorPropertiesBase, etc.) appear to skip properties that vary by culture if the parent content type itself is invariant. A warning is logged:

property data with id: {id} references a language that does not exist - language id: null (property type: "{propertyName}", id: {propertyId}, alias: "{propertyAlias}")

Specifics

The migration process erroneously detects a culture-varying property on an invariant parent content type as using a non-existing language when in reality, it is not using any language. This can happen when a composition with culture variation is added to an invariant content type.

Steps to reproduce

1. Start with an Umbraco 13 project.
2. Create a new composition and enable "allow vary by culture".
3. Add a new property with alias and name "myCultureVaryingProperty".
4. Create a new Block Grid as the editor for the property.
5. Create a new document type that does not vary by culture.
6. Add the new composition as a composition to the new document type.
7. Create a new document based on the new document type and fill out "myCultureVaryingProperty".
8. Inspect the database and observe that the values for the nested "content" property are stored without an associated language (languageId is NULL):

   SELECT 
       pd.id,
       pt.alias,
       pt.variations,
       pd.languageId,
       pd.textValue
   FROM umbracoPropertyData pd
   JOIN cmsPropertyType pt ON pd.propertyTypeId = pt.id
   WHERE 
       pt.alias = 'myCultureVaryingProperty';

9. Upgrade the site to Umbraco 15 and run migrations.
10. Check the logs and the migrated data (use the same SQL query as before).

Expected result / actual result

Expected result
The property data is migrated to the new v15 format.

Actual result
The migration skips this property and a warning is logged:

property data with id: {id} references a language that does not exist - language id: null (property type: "myCultureVaryingProperty", id: {propertyId}, alias: "myCultureVaryingProperty")

The property data is not migrated as expected.

[github-actions]

Hi there @giano574!

Firstly, a big thank you for raising this issue. Every piece of feedback we receive helps us to make Umbraco better.

We really appreciate your patience while we wait for our team to have a look at this but we wanted to let you know that we see this and share with you the plan for what comes next.

• We'll assess whether this issue relates to something that has already been fixed in a later version of the release that it has been raised for.
• If it's a bug, is it related to a release that we are actively supporting or is it related to a release that's in the end-of-life or security-only phase?
• We'll replicate the issue to ensure that the problem is as described.
• We'll decide whether the behavior is an issue or if the behavior is intended.

We wish we could work with everyone directly and assess your issue immediately but we're in the fortunate position of having lots of contributions to work with and only a few humans who are able to do it. We are making progress though and in the meantime, we will keep you in the loop and let you know when we have any questions.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

[AndyButland]

Thanks for the report @giano574 - I think I can see what's going on here, and have looked to resolve in #22167.

[giano574]

Thank you for the incredibly short response time and nice solution @AndyButland. Looking forward to seeing it merged.

[AndyButland]

Fixed via #22167 for 17.3. This didn't make the 17.3.0-rc release but we'll include it for a second release candidate next week.