V14: Move towards get guid#15889

Merged

bergmania merged 22 commits intov14/devfrom

v14/feature/move-towards-get-guid

Apr 11, 2024

Member

Zeegaan commented Mar 15, 2024

Notes

As most Get(Guid key) methods are not cached, it can hurt performance, thus this PR amends this.
There are 2 possible solutions, and they are by chance both implemented in this respectively for members & users.

For members, we now "map" the key to id, the IdKeyMap used Is cached, and thus this conversion from key -> id is fast.
For users however, we have refactored it to be the other way around, so getting by ID is not cached (this is only used in obsolete methods/tests), and the GetByKey is now cached.
This comes with a refactor of the UserRepository that is now a Guid RepositoryBase.
Updated UserCacheRefreshers, to also update the GUID in the cache (aka, just remove it)

Zeegaan added 7 commits

March 14, 2024 12:41


          Implement using keymap for member

c055c61


          Remove current usages of GetUserById

6c1c2bd


          User userId resolver to resolve user key

daeb195


          Refactor user repository to use GUID not int

0d9a3de


          Add happy path test

b8466ab


          Remove user in cache when user gets updated

1adc45e


          Use await in async method

14fdf07

kjac self-requested a review

March 18, 2024 06:14


          Merge branch 'v14/dev' into v14/feature/move-towards-get-guid

3fca4d1

kjac reviewed

View reviewed changes

src/Umbraco.Cms.Api.Management/Controllers/AuditLog/CurrentUserAuditLogController.cs Outdated

kjac reviewed

View reviewed changes

src/Umbraco.Core/Cache/DistributedCacheExtensions.cs Outdated

kjac reviewed

View reviewed changes

src/Umbraco.Core/Events/UserNotificationsHandler.cs

kjac reviewed

View reviewed changes

src/Umbraco.Core/Handlers/AuditNotificationsHandler.cs

kjac reviewed

View reviewed changes

src/Umbraco.Core/Services/MemberService.cs

kjac reviewed

View reviewed changes

src/Umbraco.Core/Services/MetricsConsentService.cs Outdated

kjac reviewed

View reviewed changes

src/Umbraco.Web.Common/Security/BackofficeSecurity.cs

kjac reviewed

View reviewed changes

src/Umbraco.Core/Cache/Refreshers/Implement/UserCacheRefresher.cs

kjac reviewed

View reviewed changes

src/Umbraco.Infrastructure/Persistence/Repositories/Implement/UserRepository.cs Outdated

Zeegaan and others added 12 commits

March 21, 2024 11:42


          Fix up according to review

a75acaa


          Update IMetricsConsentService.cs to have async method

c5682e8


          Fix according to review

92ca3ba


          Fix more according to comments

526bda4


          Revert "Fix up according to review"

1688f95

This reverts commit a75acaa


          Get current backoffice user from method

e8481e3


          Update user repository delete functionality


          Fix up more test

950c735


          Try to get user by id if key fails

865e1cc


          Add user key as required claim

b9cf5f4


          Fix tests

f1ac8cc


          Merge branch 'v14/dev' into v14/feature/move-towards-get-guid

c1fd49f

# Conflicts:
#	src/Umbraco.Cms.Api.Management/Controllers/AuditLog/CurrentUserAuditLogController.cs

Zeegaan added 2 commits

April 11, 2024 12:51


          Don't set claim in BackofficeController

cad96c8


          Create constant for the Sub claim

924678d

bergmania added category/breaking release/14.0.0 labels

bergmania approved these changes

View reviewed changes

bergmania merged commit d5809da into v14/dev

bergmania deleted the v14/feature/move-towards-get-guid branch

April 11, 2024 11:53

dependabot Bot mentioned this pull request

Bump Umbraco.Cms.Core from 13.10.0 to 14.3.4 mikaelaolsson/jalles-tc-public-web#56

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category/breaking release/14.0.0