DataTypeSplit datacollector should not care about propertyEditors#15898
Merged
DataTypeSplit datacollector should not care about propertyEditors#15898
Conversation
This ensures keys are correctly assumed to be unique => safe for dictionary usage
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Quick fix for #15872
It is possible to have the same Alias for a dataEditor used as a propertyEditor and a dataEditor used as a macroparameterEditor.
The DataTypeSplit Datacollector does not care about the macroParameterEditors as they will not be migrated to v14. => only get the DataEditors from code that are used as propertyEditors thus using aliases (which should be unique) safely as dictionary keys again.