Use the correct localization keys for core property validation errors#15931
Merged
Use the correct localization keys for core property validation errors#15931
Conversation
iOvergaard
approved these changes
Mar 22, 2024
Contributor
iOvergaard
left a comment
iOvergaard
left a comment
There was a problem hiding this comment.
This looks correct, we have these keys in the client!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When performing document/media/member property validation, there are three core validation errors that can occur:
Per property one can configure specific validation error messages, but by default these are blank - which means we use error messages defined in the core instead.
Since these core error messages are localized in the client, the server has to return a localization key. And as of right now, the localization keys returned are wrong 😆 so this PR fixes the localization keys returned by the server to match those known by the client.