Merged
Conversation
…er to the data layer Duplication is because of internal modifier as we don't want to expose these temporary classes
Updated used services to use async methods
…e/document-version # Conflicts: # src/Umbraco.Cms.Api.Management/Controllers/Dictionary/Tree/ChildrenDictionaryTreeController.cs # src/Umbraco.Cms.Api.Management/Controllers/Dictionary/Tree/RootDictionaryTreeController.cs # src/Umbraco.Cms.Api.Management/Controllers/RecycleBin/RecycleBinControllerBase.cs # src/Umbraco.Cms.Api.Management/Controllers/RedirectUrlManagement/GetAllRedirectUrlManagementController.cs # src/Umbraco.Cms.Api.Management/Controllers/Tree/EntityTreeControllerBase.cs # src/Umbraco.Cms.Api.Management/Controllers/Tree/FileSystemTreeControllerBase.cs # src/Umbraco.Cms.Api.Management/DependencyInjection/DocumentBuilderExtensions.cs # src/Umbraco.Core/Services/Pagination/PaginationConverter.cs
elit0451
suggested changes
Mar 26, 2024
Contributor
elit0451
left a comment
elit0451
left a comment
There was a problem hiding this comment.
There are a lot of minor things to fix, I haven't been through all files. Can you please double-check with our other controllers/implementations to make sure we don't have to circle back to fix misalignments later 😉
elit0451
suggested changes
Mar 27, 2024
Contributor
elit0451
left a comment
elit0451
left a comment
There was a problem hiding this comment.
Hey, I still have a few comments before I get to testing 👀
- Move endpoints into their own structural section as they are also in a different swagger section - Naming improvements - Allign PresentationFactories with similar classes - Cleanup unused assignments - Cleanup refactoring comments - Improve obsoletion remarks
kjac
added a commit
that referenced
this pull request
Apr 2, 2024
1 task
Migaroez
pushed a commit
that referenced
this pull request
Apr 3, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prerequisites
Description
Adds management API endpoints for
Testing
Breaking changes