Respect backoffice login returnPath regression

[jrunestone]

Prerequisites

Fixes #15686 (was originally fixed in 2022/2023)

Description

See issue for detailed info and how to reproduce.

Looks like while implementing the new login screen a typo was made that means the redirect url is never carried on.

There is however another part to this: in some situations when you try to directly go to a protected backoffice page (e.g. /umbraco#/settings) while not being logged in and not using basic authentication as in the issue, you are redirected to the login page but without the returnPath query parm. The redirect itself is done here https://github.com/umbraco/Umbraco-CMS/blob/v13/contrib/src/Umbraco.Web.BackOffice/Controllers/BackOfficeController.cs#L141 but I'm not sure how/where the hash part of the query is carried on on the client.

[github-actions]

Hi there @jrunestone, thank you for this contribution! 👍

While we wait for one of the Core Collaborators team to have a look at your work, we wanted to let you know about that we have a checklist for some of the things we will consider during review:

• It's clear what problem this is solving, there's a connected issue or a description of what the changes do and how to test them
• The automated tests all pass (see "Checks" tab on this PR)
• The level of security for this contribution is the same or improved
• The level of performance for this contribution is the same or improved
• Avoids creating breaking changes; note that behavioral changes might also be perceived as breaking
• If this is a new feature, Umbraco HQ provided guidance on the implementation beforehand
• 💡 The contribution looks original and the contributor is presumably allowed to share it

Don't worry if you got something wrong. We like to think of a pull request as the start of a conversation, we're happy to provide guidance on improving your contribution.

If you realize that you might want to make some changes then you can do that by adding new commits to the branch you created for this work and pushing new commits. They should then automatically show up as updates to this pull request.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

[mikecp]

Hi @jrunestone,

Thanks for providing a fix for this issue (again 😅 ?). A member of the core collaborators team will have a look at it soon.

Cheers and have a great week!

[Matthew-Wise]

Thanks @jrunestone I have also confirmed its working in 14, so you wont need to do it again :D

Have a great weekend!

[thomashdk]

Hi

When user login from this url:
xxx.dk/umbraco#/content/content/edit/2082?mculture=da

after they login, they are redirected to:
xxx.dk/umbraco#/content?mculture=da

Normally they when just end on that node they where on before.
Have notest it started happen in Umbraco 13.

I hoped this fixed it, but it didn't

Running 13.4.0

[jrunestone]

@thomashdk As I stated in my description there's another part of the problem that this PR doesn't address and that's when logging in (in my case with an external login provider) and then being redirected back to Umbraco, the returnPath=xxx param isn't even sent along back to Umbraco. But now, if it is sent along, it will be honored : - )

That might be your problem (as well as mine). I haven't had a chance to look at that part yet.

[thomashdk]

@thomashdk As I stated in my description there's another part of the problem that this PR doesn't address and that's when logging in (in my case with an external login provider) and then being redirected back to Umbraco, the returnPath=xxx param isn't even sent along back to Umbraco. But now, if it is sent along, it will be honored : - )

That might be your problem (as well as mine). I haven't had a chance to look at that part yet.

Hi..

Okay, we are not using any external login provider here. So it's just raw Umbraco login, that are not sending the user to where them came from on login or from a bookmarked link..

[ronaldhoek]

Okay, we are not using any external login provider here. So it's just raw Umbraco login, that are not sending the user to where them came from on login or from a bookmarked link..

Same here (using version 13.5.3)

[teeto]

Using 13.8.1 and i send an email to the umbraco web admin with a link to a content and if he is not logged in, it still doesnt redirect after login succesful

[DempseySbaiz]

Same here, redirect uri is still not respected on latest v13. After login it just redirects to the root content.
Not using external login provider.