v14: Add async methods to Deploy interfaces#16055
Merged
Conversation
…or and IValueConnector
bergmania
approved these changes
Apr 15, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With most (if not all) services in v14 having async implementations (and new services even exclusively), this adds async methods to the Deploy interfaces, so we can implement 'async all the way'.
I've added these new async methods in a backwards-compatible way using default implementations that return
Task.FromResult(...)and call the existing sync method. To signal to all callers and implementers to use the async methods, I've made the sync methods obsolete. This should allow us to first ensure the new async methods are implemented and called everywhere, remove the default implementations in the next major and finally remove the sync methods after being obsoleted for 2 major versions.