Skip to content

Fix data parsing error for dropdown and checkbox list #16132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Zeegaan merged 1 commit into from
Apr 25, 2024
Merged

Fix data parsing error for dropdown and checkbox list #16132

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 0 additions & 19 deletions src/Umbraco.Infrastructure/PropertyEditors/MultipleValueEditor.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,25 +29,6 @@ public MultipleValueEditor(
: base(localizedTextService, shortStringHelper, jsonSerializer, ioHelper, attribute) =>
_jsonSerializer = jsonSerializer;

/// <summary>
/// Override so that we can return an array to the editor for multi-select values
/// </summary>
/// <param name="property"></param>
/// <param name="culture"></param>
/// <param name="segment"></param>
/// <returns></returns>
public override object ToEditor(IProperty property, string? culture = null, string? segment = null)
{
var json = base.ToEditor(property, culture, segment)?.ToString();
string[]? result = null;
if (json is not null)
{
result = _jsonSerializer.Deserialize<string[]>(json);
}

return result ?? Array.Empty<string>();
}

/// <summary>
/// When multiple values are selected a json array will be posted back so we need to format for storage in
/// the database which is a comma separated string value
Expand Down