Conversation
Nuklon
reviewed
Apr 24, 2024
Nuklon
reviewed
Apr 25, 2024
Comment on lines
+22
to
+27
| public record JsonPayload | ||
| { | ||
| public int Id { get; init; } | ||
|
|
||
| #region Refresher | ||
| public Guid Key { get; init; } | ||
| } |
Contributor
There was a problem hiding this comment.
This creates a lot of bulk, can also be a class.
Member
Author
There was a problem hiding this comment.
This is the general pattern used for these JsonPayloads, see ContentCacheRefresher & MemberCacheRefresher 😁
And IMO records are the correct type here (also the plan to change the others) as this is used purely to pass data 😊
Contributor
There was a problem hiding this comment.
The compiler creates a lot of unnecessary code for records, these simple types are better suited for a regular class.
bergmania
approved these changes
Apr 25, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Notes
How to test
UserRepository.Get(int id)methodGetCacheItemshould return null (not in the cacheGetCacheItemshould now have a user.GetCacheItemreturns null (Updated user should NOT be in the cache)