Skip to content

V14: Fixup webhook endpoints#16143

Merged
elit0451 merged 2 commits intov14/devfrom
v14/bugfix/fixup-webhook-endpoints
Apr 24, 2024
Merged

V14: Fixup webhook endpoints#16143
elit0451 merged 2 commits intov14/devfrom
v14/bugfix/fixup-webhook-endpoints

Conversation

@Zeegaan
Copy link
Copy Markdown
Member

@Zeegaan Zeegaan commented Apr 24, 2024

Notes

  • The webhook get endpoint to get all webhooks did not work, as it would throw an error about not knowing how to map, this has been fixed by using the Presentation factory instead, as there is no WebhookMapDefinition
  • The item endpoint would always return 0 items, as the GetByIdsAsync webhook repository method did not work, this has been remedied by refactoring the method to have similar functionality to GetAsync

How to test

  • Start on v13
  • Create a couple of webhooks
  • Migrate to v14 (this branch)
  • Call the webhook get endpoint to get all webhooks, this should return the correct number.
  • Call the item endpoint for webhook, with one or more ids (you can get these ids from the all endpoint you just called), and assert it returns the correct number of items

Copy link
Copy Markdown
Contributor

@elit0451 elit0451 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 💪

@elit0451 elit0451 merged commit fc9b47a into v14/dev Apr 24, 2024
@elit0451 elit0451 deleted the v14/bugfix/fixup-webhook-endpoints branch April 24, 2024 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants