Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Notes
webhookget endpoint to get all webhooks did not work, as it would throw an error about not knowing how to map, this has been fixed by using the Presentation factory instead, as there is noWebhookMapDefinitionitemendpoint would always return 0 items, as theGetByIdsAsyncwebhook repository method did not work, this has been remedied by refactoring the method to have similar functionality toGetAsyncHow to test
webhookget endpoint to get all webhooks, this should return the correct number.itemendpoint for webhook, with one or more ids (you can get these ids from the all endpoint you just called), and assert it returns the correct number of items