Skip to content

Persist claims from OnExternalLogin event#16180

Merged
bergmania merged 3 commits intov14/devfrom
v14/bugfix/persist-claims-from-onexternallogin-event
Apr 29, 2024
Merged

Persist claims from OnExternalLogin event#16180
bergmania merged 3 commits intov14/devfrom
v14/bugfix/persist-claims-from-onexternallogin-event

Conversation

@bergmania
Copy link
Copy Markdown
Member

Description

This PR Ensures claims added in the OnExternalLogin are actually persisted in the tokens we store.

The issue before was we did not use the same ClaimsPricipal when calling OpenIddict as the one used doing External Login

Copy link
Copy Markdown
Contributor

@kjac kjac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great 💪

@bergmania bergmania changed the title Persist claims from InExternalLogin event Persist claims from OnExternalLogin event Apr 29, 2024
@bergmania bergmania merged commit 976146b into v14/dev Apr 29, 2024
@bergmania bergmania deleted the v14/bugfix/persist-claims-from-onexternallogin-event branch April 29, 2024 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants