Skip to content

Management api should use datetimeoffset#16196

Merged
nikolajlauridsen merged 6 commits intov14/devfrom
v14/bugfix/management-api-should-use-datetimeoffset
May 7, 2024
Merged

Management api should use datetimeoffset#16196
nikolajlauridsen merged 6 commits intov14/devfrom
v14/bugfix/management-api-should-use-datetimeoffset

Conversation

@bergmania
Copy link
Copy Markdown
Member

Description

Builds on top of #16170

This updates datetime to datetimeoffset in the management api and uses the LocalDateTime when using it.

Test

  • Ensure the endpoints continue to work
  • Try to use times with timezone info in management api, and ensure the times are "converted" to the server time

Copy link
Copy Markdown
Contributor

@nikolajlauridsen nikolajlauridsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Base automatically changed from v14/fix/move-audit-log-endpoints to v14/dev May 1, 2024 10:07
…ugfix/management-api-should-use-datetimeoffset

# Conflicts:
#	src/Umbraco.Cms.Api.Management/Controllers/Document/GetAuditLogDocumentController.cs
#	src/Umbraco.Cms.Api.Management/Controllers/Media/GetAuditLogMediaController.cs
#	src/Umbraco.Core/Services/AuditService.cs
@nikolajlauridsen nikolajlauridsen merged commit 2260da2 into v14/dev May 7, 2024
@nikolajlauridsen nikolajlauridsen deleted the v14/bugfix/management-api-should-use-datetimeoffset branch May 7, 2024 06:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants