Conversation
rasmusjp
force-pushed
the
feature/webhook-improvements
branch
2 times, most recently
from
16c885a to
c6c1e34
Compare
| return webhooksResource.getLogs(skip, take) | ||
| .then(data => { | ||
| vm.logs = data.items; | ||
| vm.pagination.totalPages = Math.ceil(data.totalItems/vm.pagination.pageSize); |
There was a problem hiding this comment.
Doesn't resource return a totalPages property simillar to users for example?
https://github.com/umbraco/Umbraco-CMS/blob/v13/dev/src/Umbraco.Web.UI.Client/src/views/users/views/users/users.controller.js#L730
There was a problem hiding this comment.
Not for this endpoint, it uses skip/take for pagination so totalPages always returns 0
There was a problem hiding this comment.
Okay, perhaps it should have a getPagedLogs()
https://github.com/umbraco/Umbraco-CMS/blob/v13/dev/src/Umbraco.Web.UI.Client/src/common/resources/webhooks.resource.js#L39
GetLogs() returns a PagedResult<T>:
https://github.com/umbraco/Umbraco-CMS/blob/v13/dev/src/Umbraco.Web.BackOffice/Controllers/LogViewerController.cs#L94
which has totalPages property:
https://github.com/umbraco/Umbraco-CMS/blob/contrib/src/Umbraco.Core/Models/PagedResultOfT.cs#L11
https://github.com/umbraco/Umbraco-CMS/blob/contrib/src/Umbraco.Core/Models/PagedResult.cs#L34-L35
but I guess it would need to populate totalPages here. Perhaps it could handle the logic server side here?
https://github.com/umbraco/Umbraco-CMS/blob/v13/dev/src/Umbraco.Web.BackOffice/Controllers/LogViewerController.cs#L108
rasmusjp
force-pushed
the
feature/webhook-improvements
branch
3 times, most recently
from
5b3c4ec to
9ed1329
Compare
rasmusjp
force-pushed
the
feature/webhook-improvements
branch
from
9ed1329 to
b122621
Compare
| return "JSON"; | ||
| if (contentType === "text/html") | ||
| return "HTML"; | ||
| if (contentType === "application/xml" || contentType === "text/xml") |
There was a problem hiding this comment.
Should we include application/rss+xml and application/atom+xml as well?
Not sure how common it is with webhooks, but I guess to potentially could:
https://community.zapier.com/code-webhooks-52/rss-feed-trigger-app-returns-not-acceptable-28640
|
LGTM 🚀 |
* Updates JSON schema for Umbraco 10 with latest references for Forms and Deploy (#15918) * Ported over #15928 changes for 13.3 RC (#16023) * Ported over #15928 changes for 13.3 RC * Use GetOrAdd() * Lock dictionary initialization --------- Co-authored-by: Jason Elkin <jasonelkin86@gmail.com> * Make the API content response builder extendable (#16056) * Make the API content response builder extendable * DeliveryApiJsonTypeResolver needs to be extendable too * bump rc to regular * Bump to next minor * Add blocks in RTE telemetry (#16104) * Add blocks telemetry * Use constants and update tests * V13: Add property type information to telemetry (#16109) * Add property type counts to telemetry * Use constants and fix tests * Update description * V10: Fix for fallback file upload (#14892) (#15868) * Fix for fallback file upload (#14892) * Added check for file type * Removed unneeded null checks and fixed tabs * Cleaning * Cleanups, cleanups, and removal of unneeded null checks * Reverted removal of relationshipservice * Revert null check removals (too risky) --------- Co-authored-by: Ambert van Unen <AvanUnen@ilionx.com> Co-authored-by: Laura Neto <12862535+lauraneto@users.noreply.github.com> (cherry picked from commit 0b5d1f8) * Fix up formatting --------- Co-authored-by: Ambert van Unen <ambertvu@gmail.com> * Implementors using Umbraco.Tests.Integration won't have to override GetLocalizedTextService (cherry picked from commit b001668) (cherry picked from commit 2bb56f1) * Fix logic for retrieving lastKnownElement (cherry picked from commit cae106b) * bump version * Bump version * Bump version * Since v13 properties can sometimes be of type IRichTextEditorIntermediateValue - this was unexpected in the XPath navigator code (#16121) * Webhook log improvements (#16200) * fix: include all headers in webhook log * feat: return webhook log status from server * feat: make webhook logs deep linkable * feat: add webhook log pagination * feat: improve webhook request/response body preview * V13: Optimize custom MVC routing (#16218) * Introduce EagerMatcherPolicy to conditionally bypass content routing * Ensure that the candidate we disable dynamic routing for is valid * Skip Umbraco endpoints * Simplify logic a bit * Move install logic to matcher * Ensure that dynamic routing is still skipped when in upgrade state * Fixup comments * Reduce nesting a bit * Don't show maintenance page when statically routed controllers are hít * Remove excess check, since installer requests are statically routed * V13: Optimize custom MVC routing (#16218) * Introduce EagerMatcherPolicy to conditionally bypass content routing * Ensure that the candidate we disable dynamic routing for is valid * Skip Umbraco endpoints * Simplify logic a bit * Move install logic to matcher * Ensure that dynamic routing is still skipped when in upgrade state * Fixup comments * Reduce nesting a bit * Don't show maintenance page when statically routed controllers are hít * Remove excess check, since installer requests are statically routed (cherry picked from commit ba9ddd1) * Property source level variation should only be applied when configured (#16270) * Property source level variation should only be applied when configured (#16270) (cherry picked from commit ab32bac) * Merge pull request from GHSA-j74q-mv2c-rxmp * Merge pull request from GHSA-j74q-mv2c-rxmp * Merge pull request from GHSA-j74q-mv2c-rxmp * Fix up after merge * Remove obselete test --------- Co-authored-by: Andy Butland <abutland73@gmail.com> Co-authored-by: Kenn Jacobsen <kja@umbraco.dk> Co-authored-by: Jason Elkin <jasonelkin86@gmail.com> Co-authored-by: Sven Geusens <sge@umbraco.dk> Co-authored-by: Mole <nikolajlauridsen@protonmail.ch> Co-authored-by: Ambert van Unen <ambertvu@gmail.com> Co-authored-by: Lars-Erik <lars-erik@aabech.no> Co-authored-by: Joshua Daniel Pratt Nielsen <jdpnielsen@gmail.com> Co-authored-by: Bjarke Berg <mail@bergmania.dk> Co-authored-by: Sebastiaan Janssen <sebastiaan@umbraco.com> Co-authored-by: Rasmus John Pedersen <mail@rjp.dk>
4 participants
Description
Made some improvements to the webhook logs.
Content.Headers2xxresponsesBefore:
After:
