Allow FileUpload and Imagecropper to upload files in the same way#16214
Merged
leekelleher merged 9 commits intov14/devfrom May 13, 2024
Merged
Conversation
… format remains the file path
4 tasks
Member
|
Backoffice PR umbraco/Umbraco.CMS.Backoffice#1764 has been approved and merged in. 👍 |
leekelleher
deleted the
v14/feature/handle-fileuploads-and-imagecropper-uploads-in-the-same-way
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Warning
Do not merge without the backoffice client PR umbraco/Umbraco.CMS.Backoffice#1764
This PR aligns how file upload and image cropper can upload images.
Now they both use json and share the same structure
{ "temporaryFileId" : "00000000-0000-0000-0000-000000000000", "src" : "..." }If
temporaryFileIdis not null ,it will replace any existingsrc.temporaryFileIdis basically only used as input.Test