V14: Login page throws validation errors#16222
Merged
iOvergaard merged 2 commits intov14/devfrom May 6, 2024
Merged
Conversation
…when we removed the shadow dom
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #16204
We need the login fields on the login page to avoid using a ShadowDOM, otherwise password managers do not work very well. We tried initially to do that by extending the UUI input elements and told Lit to remove the Shadow DOM. However, after a update on the UI library, this particular trick has stopped working and we couldn't validate the form fields anymore. This PR makes up with that fact and goes back to native html input fields specifically for the login page.