Skip to content

Use parentElement instead of parent#16257

Merged
Matthew-Wise merged 2 commits intoumbraco:v13/contribfrom
vlaellayug:temp/16256
Jun 22, 2024
Merged

Use parentElement instead of parent#16257
Matthew-Wise merged 2 commits intoumbraco:v13/contribfrom
vlaellayug:temp/16256

Conversation

@vlaellayug
Copy link
Copy Markdown
Contributor

@vlaellayug vlaellayug commented May 10, 2024

Checking the focusabeElements object it contains the following fields:

image

I didn't see any parent field, so used the parentElement instead.

This fixes #16256

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 10, 2024

Hi there @vlaellayug, thank you for this contribution! 👍

While we wait for one of the Core Collaborators team to have a look at your work, we wanted to let you know about that we have a checklist for some of the things we will consider during review:

  • It's clear what problem this is solving, there's a connected issue or a description of what the changes do and how to test them
  • The automated tests all pass (see "Checks" tab on this PR)
  • The level of security for this contribution is the same or improved
  • The level of performance for this contribution is the same or improved
  • Avoids creating breaking changes; note that behavioral changes might also be perceived as breaking
  • If this is a new feature, Umbraco HQ provided guidance on the implementation beforehand
  • 💡 The contribution looks original and the contributor is presumably allowed to share it

Don't worry if you got something wrong. We like to think of a pull request as the start of a conversation, we're happy to provide guidance on improving your contribution.

If you realize that you might want to make some changes then you can do that by adding new commits to the branch you created for this work and pushing new commits. They should then automatically show up as updates to this pull request.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

@mikecp
Copy link
Copy Markdown
Contributor

mikecp commented May 10, 2024

Hi @vlaellayug ,

Thanks a lot for spotting this issue and providing the fix 👍
Since this is a fix for V13, it will come in the next V13 patch release, which I don't think we have a specific date for 😅
But a member of the core collaborators team will have a look at it soon in order to get it in "asap".

Cheers!

@vlaellayug vlaellayug changed the title Added null checker for umb-tab when it's trying to get the elm.parent Use parentElement instead of parent May 10, 2024
@Matthew-Wise Matthew-Wise changed the base branch from contrib to v13/contrib June 22, 2024 10:32
@Matthew-Wise Matthew-Wise self-assigned this Jun 22, 2024
@Matthew-Wise Matthew-Wise merged commit 4e746d3 into umbraco:v13/contrib Jun 22, 2024
@Matthew-Wise
Copy link
Copy Markdown
Contributor

Hi @vlaellayug

Thanks for the PR this has been merged and will be in the next v13 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Umbraco directives console error

4 participants