V13: Fix routing with string parameter#16344
Merged
Conversation
This was
linked to
issues
May 22, 2024
bergmania
pushed a commit
that referenced
this pull request
May 22, 2024
(cherry picked from commit eb6bb99)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes routing when a string parameter is used
This was caused by #16218 not considering invalid candidates
Fixes #16332 and #16341
Teting:
Create a site with a URL with more than one segment I.E
Add an attribute routed endpoint with a string I.E.:
Ensure you can request both
/child/grandchildand/sitemap-something-xml