Fix issues with initial creation of external users#16363
Merged
iOvergaard merged 2 commits intov14/devfrom May 24, 2024
Merged
Conversation
iOvergaard
approved these changes
May 24, 2024
Contributor
iOvergaard
left a comment
iOvergaard
left a comment
There was a problem hiding this comment.
Looks good to me and tests well 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
After logging in with an external user for the first time, the Management API is unable to resolve the current user. Turns out we are mapping an empty user key in the "sub" claim.
While I was digging through the codebase to find the error, I came across a few hardcoded
"sub"claims. I have updated those to use theOpenIdDictSubClaimTypeconstant instead.Testing
Setup external auth on a fresh DB. Log in with an external user. It should work.