Skip to content

v14: Validate file name to return correct error #16419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Migaroez merged 2 commits into from
May 31, 2024
Merged

v14: Validate file name to return correct error #16419

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3d41482
Validate name
Zeegaan May 27, 2024
3e6aaae
Add missing case for HandleRename
Zeegaan May 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/Umbraco.Core/Services/FileServiceOperationBase.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,6 +82,11 @@ protected async Task<TOperationStatus> HandleDeleteAsync(string path, Guid userK

protected async Task<Attempt<TEntity?, TOperationStatus>> HandleCreateAsync(string name, string? parentPath, string? content, Guid userKey)
{
if (name.Contains("/"))
{
return Attempt.FailWithStatus<TEntity?, TOperationStatus>(InvalidName, default);
}
Copy link
Copy Markdown
Contributor

@kjac kjac May 27, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reckon we need this both here and in HandleRenameAsync?

Copy link
Copy Markdown
Member Author

@Zeegaan Zeegaan May 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done 😁


using ICoreScope scope = ScopeProvider.CreateCoreScope();

var path = GetFilePath(parentPath, name);
Expand Down